Fix flaky tests for vectors #844
Merged
+7
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lojjs
force-pushed
the
vector-flaky-tests
branch
from
cf3e8ca to
2144361
Compare
loveleif
approved these changes
Sep 25, 2025
| final var rand = RandomValues.create(new Random(seed)); | ||
| final var randStorables = stream(ValueType.values()) | ||
| .filter(t -> t.valueGroup.category().equals(ValueCategory.VECTOR)) | ||
| .filter(t -> !t.valueGroup.category().equals(ValueCategory.VECTOR)) |
There was a problem hiding this comment.
Shouldn't we fix this? Hash should be stable on vectors too?
There was a problem hiding this comment.
Yes, that is probably a better idea. I added the feature flags to this test file too and then the tests seem to pass without this line
Lojjs
force-pushed
the
vector-flaky-tests
branch
from
9f18b1b to
896f542
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.