Skip to content

Images refresh batch 2 #2541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 27 commits into
base: dev
Choose a base branch
from
Open

Images refresh batch 2 #2541

wants to merge 27 commits into from

Conversation

lidiazuin
Copy link
Contributor

No description provided.

lidiazuin and others added 6 commits August 15, 2025 13:50
@lidiazuin
Merge branch 'dev' into imgrefresh-batch2
86a6ef6
@Hunterness @mnd999
@renetapopova @lidiazuin
Add documentation for the alter database privileges on database level (…
ed6b904 
…neo4j#2490)

Since we moved them over from DBMS level (while still keeping the DBMS
level syntax, just as another syntax for `DATABASE *`)

---------

Co-authored-by: Mark Dixon <1756429+mnd999@users.noreply.github.com>
Co-authored-by: Reneta Popova <reneta.popova@neo4j.com>
@NataliaIvakina @lidiazuin
Update the description of the history option (neo4j#2543)
fc82a2d
@NataliaIvakina @lidiazuin
Add tabbed examples for multiple node IDs (neo4j#2512)
fe668fb 
The Operations manual covers all releases of 2025.xx series. That's why
we cannot simply replace examples with new ones, as new functionality
has been added. We also need to retain examples for earlier versions of
Neo4j.
@lidiazuin
Images refresh batch 2
879932c
@lidiazuin
Merge branch 'dev' into imgrefresh-batch2
bfb7692
Hunterness
Hunterness reviewed Aug 29, 2025
View reviewed changes
renetapopova
renetapopova requested changes Sep 8, 2025
View reviewed changes
Copy link
Collaborator

@renetapopova renetapopova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @lidiazuin. They all look good from a visual perspective but I've found some inconsistencies and things that might lead to misunderstandings.

modules/ROOT/images/privileges-hierarchy-database.svg
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alter database is missing
Screenshot 2025-09-08 at 13 04 42

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2541 (comment) I also noticed this :P

modules/ROOT/images/privileges-grant-and-deny-syntax-dbms-privileges.svg
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-09-08 at 13 17 15

Copy link
Collaborator

@renetapopova renetapopova Sep 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-09-08 at 13 19 37

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image I think some of your image comments doesn't load?

modules/ROOT/images/privileges-hierarchy-dbms.svg
Copy link
Collaborator

@renetapopova renetapopova Sep 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-09-08 at 13 31 37

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The connections that you noted that don't derive from the same place are all coming from ALL DBMS PRIVILEGES, that's the style of the arrows used in the technical diagrams. I can try to change the style, but just letting you know that this is the default styling.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought so, but they look misleading, so I decided to tell you if you can change them somehow.

modules/ROOT/images/privileges-hierarchy.svg
Copy link
Collaborator

@renetapopova renetapopova Sep 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-09-08 at 13 54 58

Hunterness
Hunterness reviewed Sep 10, 2025
View reviewed changes
Copy link
Contributor

@Hunterness Hunterness left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review of current state

Status: 1 open comment

Hunterness
Hunterness reviewed Sep 15, 2025
View reviewed changes
Hunterness
Hunterness reviewed Sep 16, 2025
View reviewed changes
Copy link
Contributor

@Hunterness Hunterness left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next round of comments, a lot of them on missing/to much bold :P

Hunterness
Hunterness reviewed Sep 18, 2025
View reviewed changes
Copy link
Contributor

@Hunterness Hunterness left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at most of the updates (skipping the file that now seems duplicated as I don't want to review both and I don't know which is the latest, this also means that all open comments on that file is left as is until I can tick them off)

Status: 1 open comment

modules/ROOT/images/privileges-grant-and-deny-syntax-database-privileges.svg
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small general nitpick I noticed as I compare with the old ones:
in the *|x[, ...] groups we previously only had the x part italic and not the * (or () or other such syntax characters).
Examples (both from this and other images):

  • (*|user[, ...])
  • *|name[, ...]
  • TO role[, ...]
  • {*|property[, ...]}

Hunterness
Hunterness reviewed Sep 19, 2025
View reviewed changes
Copy link
Contributor

@Hunterness Hunterness left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next round of review, still some older comments left as well

Status: 1 open comment

modules/ROOT/images/privileges-grant-and-deny-syntax.svg
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DATABASE[S] should not be bold

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not bold.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll give you that when I zoom in, but in the full view it looks different than the others so something is different about it even if it isn't bold 🤔
image
image

Hunterness
Hunterness reviewed Sep 24, 2025
View reviewed changes
Copy link
Contributor

@Hunterness Hunterness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-review

Hunterness
Hunterness reviewed Sep 25, 2025
View reviewed changes
Copy link
Contributor

@Hunterness Hunterness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the old comments I had left now are minor things, but noticed one more thing as I looked through the updates

@neo4j-docops-agent
Copy link
Collaborator

This PR includes documentation updates
View the updated docs at https://neo4j-docs-operations-2541.surge.sh

Updated pages:

Hunterness
Hunterness approved these changes Sep 25, 2025
View reviewed changes
Copy link
Contributor

@Hunterness Hunterness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor things left that I'm less picky about

NataliaIvakina
NataliaIvakina approved these changes Sep 26, 2025
View reviewed changes
Copy link
Collaborator

@NataliaIvakina NataliaIvakina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Awesome! I don't find any typos on the diagrams.
Only one quick question: the vertical diagram Syntax of GRANT and DENY DBMS privileges actually becomes smaller if you click on it. Is this expected?
All other diagrams are horizontal and they appear larger and closer if you click on them. Only this vertical diagram behaves differently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hunterness Hunterness Hunterness approved these changes

@NataliaIvakina NataliaIvakina NataliaIvakina approved these changes

@renetapopova renetapopova Awaiting requested review from renetapopova

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
cherry-pick-this-to-main
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lidiazuin @neo4j-docops-agent @Hunterness @renetapopova @NataliaIvakina