Skip to content

Conversation

renetapopova
Copy link
Collaborator

No description provided.

@recrwplay
Copy link
Contributor

This PR includes documentation updates
View the updated docs at https://neo4j-docs-status-codes-275.surge.sh

Updated pages:

@renetapopova
Copy link
Collaborator Author

Hey @Lojjs, I've also created 3 cards folowing our discussions on Thursday. I wonder if we want to doble-check with one more person, for example, Lasse, if the parameters' descriptions make sense to him as well.

Copy link
Contributor

@Lojjs Lojjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some smaller things. Feel free to ask Lasse or Natalia for a review too if you want another pair of eyes on it as I have cowritten it

Copy link
Contributor

@Lojjs Lojjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvement 🚀

renetapopova and others added 6 commits March 21, 2025 11:21
Co-authored-by: Lasse Heemann <7661319+l-heemann@users.noreply.github.com>
Co-authored-by: Lasse Heemann <7661319+l-heemann@users.noreply.github.com>
Co-authored-by: Lasse Heemann <7661319+l-heemann@users.noreply.github.com>
Co-authored-by: Lasse Heemann <7661319+l-heemann@users.noreply.github.com>
Co-authored-by: Lasse Heemann <7661319+l-heemann@users.noreply.github.com>
Co-authored-by: Lasse Heemann <7661319+l-heemann@users.noreply.github.com>
@neo-technology-commit-status-publisher
Copy link
Collaborator

neo-technology-commit-status-publisher commented Mar 24, 2025

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

//52N22 and 52N36 to change $field to $arg. Check 22N98 with Antonio.
[[fun]]$fun:: Function name, for example, `collect()`.
[[funClass]]$funClass:: User-defined function implementation class name, for example, `MyFunctionClass`.
[[graph]]$graph:: The name of a graph, for example, `myGraph`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, is this parameter for GDS-related features?
How do we (in the team-errors) define and distinguish graph and database?
We have these terms in the Neo4j Glossary. Are those definitions still true and valid?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe graph here is unrelated to the graph in GDS, both referencing the scientific concept that Neo4j builds on https://en.wikipedia.org/wiki/Graph_theory.

@nadja-muller Do you have a more detailed explanation for the graph vs database question? I attempted an example with composite but that felt more confusing than helpful 😅

Copy link
Contributor

@nadja-muller nadja-muller Mar 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit tricky. I think what we ended up on was:

  • graph: logical object, data in the database container e.g. once you access the data, you try to access the graph (which is why it is used as a target of the USE clause)
  • database: container/file of the graph (which is why it is used in the administration commands)

I'm not sure how to write this out formally, however. There are very close to each other. Does that help you?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@l-heemann, are you happy with this PR? May I merge it?

@renetapopova renetapopova merged commit ed4842d into neo4j:dev Mar 24, 2025
4 checks passed
@renetapopova renetapopova deleted the dev-parameters branch March 24, 2025 15:07
renetapopova added a commit to renetapopova/docs-status-codes that referenced this pull request Mar 24, 2025
Co-authored-by: Lasse Heemann <7661319+l-heemann@users.noreply.github.com>
renetapopova added a commit that referenced this pull request Mar 24, 2025
Cherry-picked from #275

Co-authored-by: Lasse Heemann <7661319+l-heemann@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants