Skip to content

Update conditions and messages of 22N51, 42N00, 42N11, 25N05, 42N39, 22N06, 42N08, 51N12, 51N27 #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Mar 24, 2025
Merged

Update conditions and messages of 22N51, 42N00, 42N11, 25N05, 42N39, 22N06, 42N08, 51N12, 51N27 #282

merged 12 commits into from
Mar 24, 2025

Conversation

NataliaIvakina
Copy link
Collaborator

No description provided.

@NataliaIvakina NataliaIvakina changed the title Update conditions and messages of 22N51, 42N00, 42N11, 25N05, and 42N39 Update conditions and messages of 22N51, 42N00, 42N11, 25N05, 42N39, and 42I13 Mar 20, 2025
NataliaIvakina
NataliaIvakina commented Mar 20, 2025
View reviewed changes
NataliaIvakina
NataliaIvakina commented Mar 20, 2025
View reviewed changes
@NataliaIvakina NataliaIvakina changed the title Update conditions and messages of 22N51, 42N00, 42N11, 25N05, 42N39, and 42I13 Update conditions and messages of 22N51, 42N00, 42N11, 25N05, 42N39, 22N06, 42N08, 51N12, 51N27 Mar 20, 2025
Lojjs
Lojjs requested changes Mar 20, 2025
View reviewed changes
Copy link
Contributor

@Lojjs Lojjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we were not very good at updating the spreadsheet, sorry about that. I have added suggestions to match what was is in the codebase

@NataliaIvakina @Lojjs
Update messages according to the code
0793745 
Co-authored-by: Louise Berglund <louise.berglund@neo4j.com>
@NataliaIvakina
Copy link
Collaborator Author

Looks like we were not very good at updating the spreadsheet, sorry about that. I have added suggestions to match what was is in the codebase

Oops 😅 I'll take this into account for future work. I assume it's better to refer to the codebaae from the beginning. Will we maintain and update this spreadsheet in future?

@renetapopova renetapopova requested a review from Lojjs March 21, 2025 10:17
renetapopova
renetapopova reviewed Mar 21, 2025
View reviewed changes
Copy link
Collaborator

@renetapopova renetapopova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment

@Lojjs
Copy link
Contributor

Lojjs commented Mar 24, 2025

Looks like we were not very good at updating the spreadsheet, sorry about that. I have added suggestions to match what was is in the codebase

Oops 😅 I'll take this into account for future work. I assume it's better to refer to the codebaae from the beginning. Will we maintain and update this spreadsheet in future?

No our current idea is that we will stop maintaining the spreadsheet in a few weeks or so (probably once 2025.04 is out and we no longer are adding so many new errors per release)

@NataliaIvakina @renetapopova
Test a role instead of labels
193ebab 
Co-authored-by: Reneta Popova <reneta.popova@neo4j.com>
NataliaIvakina
NataliaIvakina commented Mar 24, 2025
View reviewed changes
NataliaIvakina
NataliaIvakina commented Mar 24, 2025
View reviewed changes
NataliaIvakina
NataliaIvakina commented Mar 24, 2025
View reviewed changes
NataliaIvakina
NataliaIvakina commented Mar 24, 2025
View reviewed changes
@neo-technology-commit-status-publisher
Copy link
Collaborator

neo-technology-commit-status-publisher commented Mar 24, 2025 •
edited
Loading

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

@NataliaIvakina NataliaIvakina merged commit 7edd9c9 into neo4j:dev Mar 24, 2025
4 checks passed
@NataliaIvakina NataliaIvakina deleted the dev-updates-for-release branch March 24, 2025 17:12
NataliaIvakina added a commit to NataliaIvakina/docs-status-codes that referenced this pull request Mar 28, 2025
@NataliaIvakina @Lojjs @renetapopova
Update conditions and messages of 22N51, 42N00, 42N11, 25N05, 42N39, …
4df35ec 
…22N06, 42N08, 51N12, 51N27 (neo4j#282)

Co-authored-by: Louise Berglund <louise.berglund@neo4j.com>
Co-authored-by: Reneta Popova <reneta.popova@neo4j.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@renetapopova renetapopova renetapopova left review comments

@Lojjs Lojjs Lojjs approved these changes

Assignees

No one assigned

Labels

2025.03

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@NataliaIvakina @Lojjs @neo-technology-commit-status-publisher @renetapopova