Skip to content

Improve json struct types #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 20, 2023
Merged

Conversation

emmaagh
Copy link
Contributor

@emmaagh emmaagh commented Mar 17, 2023

  • Fixed some mistakes in the json struct types (relationshipObjectTypes where inside nodeObjectTypes and properties were missing $id)
  • Switched to smaller types for each part of the schema so it's clearer what's going on
  • Added types to all of the fromJsonStruct functions

@changeset-bot
Copy link

changeset-bot bot commented Mar 17, 2023

🦋 Changeset detected

Latest commit: e87db42

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@neo4j/graph-schema-utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@emmaagh
Copy link
Contributor Author

emmaagh commented Mar 17, 2023

Copy link
Member

@oskarhane oskarhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@emmaagh emmaagh merged commit 955a9e4 into neo4j:main Mar 20, 2023
@emmaagh emmaagh deleted the json-struct-helpers-2 branch March 20, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants