Use static factories to create NodeJS buffers #351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously code always used constructor to create NodeJS buffers. Constructor is overloaded to create buffer from an array, another buffer, string or with specified size. It is deprecated in newer NodeJS versions in favor of static factories like `Buffer.alloc()` and `Buffer.from()`. First allocates a buffer of the specified size. Second creates buffer based on the given string, array or another buffer. This commit makes code use static factories instead of the constructor, when available. This makes construction of buffers work in older NodeJS environments that only have the constructor and new environments, that potentially only have static factories.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously code always used constructor to create NodeJS buffers. Constructor is overloaded to create buffer from an array, another buffer, string or with specified size. It is deprecated in newer NodeJS versions in favor of static factories like
Buffer.alloc()andBuffer.from(). First allocates a buffer of the specified size. Second creates buffer based on the given string, array or another buffer.This PR makes code use static factories instead of the constructor, when available. This makes construction of buffers work in older NodeJS environments that only have the constructor and new environments, that potentially only have static factories.
Related to #336