Move non-NVL custom fields into a properties dict #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
adamnsch
force-pushed
the
entity_properties
branch
from
c9ce0b5 to
eac656b
Compare
Only `Node`, `Relationship` and `from_neo4j` updated so far. Co-Authored-By: Florentin Dörre <florentin.dorre@neotechnology.com>
adamnsch
force-pushed
the
entity_properties
branch
from
eac656b to
9763371
Compare
adamnsch
force-pushed
the
entity_properties
branch
from
f77c741 to
f8b121c
Compare
adamnsch
changed the title
FlorentinD
reviewed
Apr 17, 2025
|
|
||
|
|
||
| class PropertyType(Enum): | ||
| class ColorSpace(Enum): |
There was a problem hiding this comment.
I think I would prefer ValueSpace over ColorSpace.
Could at some doc string to clarify what we mean here
There was a problem hiding this comment.
I prefer ColorSpace as it also describes how one should interpret the colors provided to color_nodes. And a field/property can have float values, but you still might want to color it with a discrete space
There was a problem hiding this comment.
But yes, we should add doc strings
FlorentinD
approved these changes
Apr 17, 2025
|
|
||
| def from_dfs( | ||
| node_dfs: DFS_TYPE, rel_dfs: DFS_TYPE, node_radius_min_max: Optional[tuple[float, float]] = (3, 60) | ||
| def _from_dfs( |
There was a problem hiding this comment.
why the 2 methods now? the signature looks the same?
There was a problem hiding this comment.
No they're not exactly the same. See the rename_properties arg, and how the from_gds loader uses it
Co-Authored-By: Florentin Dörre <florentin.dorre@neotechnology.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution to the Graph Data Science Client project.
Before submitting this PR, please read Contributing to the Neo4j Ecosystem.
Make sure: