Skip to content

Add from_gql_create VG constructor #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 24, 2025
Merged

Add from_gql_create VG constructor #142

merged 7 commits into from
Apr 24, 2025

Conversation

adamnsch
Copy link
Collaborator

@adamnsch adamnsch commented Apr 17, 2025 •
edited
Loading

Thank you for your contribution to the Graph Data Science Client project.

Before submitting this PR, please read Contributing to the Neo4j Ecosystem.

Make sure:

  • You signed the Neo4j CLA (Contributor License Agreement) so that we are allowed to ship your code in our library
  • Your contribution is covered by tests

Remaining:

  • More docs
  • Mention in Neo4j example notebook

@adamnsch adamnsch mentioned this pull request Apr 22, 2025
Closed
2 tasks
@adamnsch adamnsch force-pushed the from-gql-create branch 2 times, most recently from 52fe692 to 731ed42 Compare April 22, 2025 14:17
@adamnsch adamnsch changed the title WIP: Add from_gql_create VG constructor Add from_gql_create VG constructor Apr 22, 2025
@adamnsch adamnsch marked this pull request as ready for review April 22, 2025 14:18
FlorentinD
FlorentinD reviewed Apr 24, 2025
View reviewed changes
FlorentinD
FlorentinD reviewed Apr 24, 2025
View reviewed changes
Copy link
Collaborator

@FlorentinD FlorentinD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think its a good intermediate solution.

The parsing logic is a bit tedious to read but test-cases have some good coverage.
until we use a proper parser i think its good enough to ship to users.
AFAIK this feature is mainly requested by Neo4j internal usage

@adamnsch @FlorentinD
Address some review comments
cec307a 
Co-Authored-By: Florentin Dörre <florentin.dorre@neotechnology.com>
adamnsch and others added 2 commits April 24, 2025 14:30
@adamnsch @FlorentinD
Add additional parsing error test case
01295fc 
Co-Authored-By: Florentin Dörre <florentin.dorre@neotechnology.com>
@adamnsch
Add support for label-less nodes to from_gql_create
4ef1c2f
@adamnsch @FlorentinD
Allow node creation from rel expression in from_gql_create
d978c96 
Co-Authored-By: Florentin Dörre <florentin.dorre@neotechnology.com>
@FlorentinD FlorentinD merged commit 0216514 into main Apr 24, 2025
11 checks passed
@adamnsch adamnsch deleted the from-gql-create branch April 24, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlorentinD FlorentinD FlorentinD left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamnsch @FlorentinD