fix(native): get filepath from line by cursor position #4553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fix brings another issue:
back to the first |
|
Can we look at how YCM implements this? I used to use YCM before moving to CoC and this feature worked well there. |
fannheyward
force-pushed
the
fix/native-file-line
branch
from
79cea6e
to
e191caf
Compare
fannheyward
force-pushed
the
fix/native-file-line
branch
from
e191caf
to
7e5c58b
Compare
fannheyward
changed the title
fannheyward
force-pushed
the
fix/native-file-line
branch
from
7e5c58b
to
8198752
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #4553 +/- ##
=======================================
Coverage 98.76% 98.76%
=======================================
Files 273 273
Lines 25913 25922 +9
Branches 5374 5376 +2
=======================================
+ Hits 25593 25602 +9
- Misses 185 186 +1
+ Partials 135 134 -1
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
Could we have one of the reviewers who have write access to review this pull request, please? |
|
@fannheyward, could you please assign a reviewer to this long-standing pull request? |
|
@oblitum please give this a test and review |
chemzqm
added a commit
that referenced
this pull request
Aug 31, 2023
15c8946 Revert "chore(package): use yarn instead" dacd62f chore(package): use yarn instead 0e6be47 fix(package): use npm 0189ace chore(inlayHint): check nvim version d81fde9 feat(inlayHint): inline display for nvim (#4648) 1038082 Allow watching workspaces at /tmp/some-dir (#4632) 34f5d96 refactor(glob): use latest glob module b2ae10c fix(type): fix bad types 5385efd chore(package): require node 16.18.0 5ea8b52 chore(README): gitter url to matrix (#4520) fc260ab fix(input): delete buffer on vim only 02c2542 fix(native): get pathstr by cursor position (#4553) 1c9c72f fix(workspaceFolder): check directory of fsPath (#4566) b1e5d71 fix(util): check $XDG_CONFIG_HOME before use as data home (#4492) abdb129 fix(input): bdel term buf (#4608) c790182 chore(doc): target of diagnosticInfo 5571414 feat(diagnostic): add target to diagnosticInfo (#4642) e4ffae5 fix(list): scrolling float preview for vim (#4647) c5a7123 feat(data): allow languageserver.env (#4658) 44898ec fix(format): formatOnSaveTimeout config with scope (#4689) d432de2 feat(links): only fetch links on documeng changed (#4690) ed89997 fix: clean unused code (#4710) 4f3b4d9 feat(handler): hasProvider can accept bufnr (#4714) 18152f2 chore(package): update dependencies bacbe49 refactor(highlighter): highligher.ts to highlighter.ts (#4730) 5423ee0 feat(completion): stop completion when navigate 29065d9 chore(doc): escape coc_status 1d36382 chore(doc): add refactor buffer section 0a2c8b8 fix: ls provider's score is equal to the default one (#4722) fab97c7 perf: return early in around and buffer source (#4721) eba04ac fix: autoActiavte to autoActivate, keeped to kept (#4716) f7545f2 docs: update outdated url (#4717)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #4549