Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(native): get filepath from line by cursor position #4553

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

fannheyward
Copy link
Member

close #4549

@fannheyward fannheyward enabled auto-merge (squash) March 6, 2023 15:45
@fannheyward
Copy link
Member Author

This fix brings another issue:

$HOME/ xxx ./

back to the first $HOME file sources, still list files in ./.

@fannheyward fannheyward marked this pull request as draft March 7, 2023 02:45
@MahdiNazemi
Copy link

Can we look at how YCM implements this? I used to use YCM before moving to CoC and this feature worked well there.

@fannheyward fannheyward marked this pull request as ready for review March 23, 2023 08:15
@fannheyward fannheyward changed the title fix(native): cut line by last space to use as path fix(native): get filepath from line by cursor position Mar 23, 2023
@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (b28b8dc) 98.76% compared to head (8198752) 98.76%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4553   +/-   ##
=======================================
  Coverage   98.76%   98.76%           
=======================================
  Files         273      273           
  Lines       25913    25922    +9     
  Branches     5374     5376    +2     
=======================================
+ Hits        25593    25602    +9     
- Misses        185      186    +1     
+ Partials      135      134    -1     
Impacted Files Coverage Δ
src/completion/native/file.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MahdiNazemi
Copy link

Could we have one of the reviewers who have write access to review this pull request, please?

@MahdiNazemi
Copy link

@fannheyward, could you please assign a reviewer to this long-standing pull request?

@fannheyward
Copy link
Member Author

@oblitum please give this a test and review

@chemzqm chemzqm merged commit 02c2542 into master Aug 31, 2023
@chemzqm chemzqm deleted the fix/native-file-line branch August 31, 2023 06:39
chemzqm added a commit that referenced this pull request Aug 31, 2023
15c8946 Revert "chore(package): use yarn instead"
dacd62f chore(package): use yarn instead
0e6be47 fix(package): use npm
0189ace chore(inlayHint): check nvim version
d81fde9 feat(inlayHint): inline display for nvim (#4648)
1038082 Allow watching workspaces at /tmp/some-dir (#4632)
34f5d96 refactor(glob): use latest glob module
b2ae10c fix(type): fix bad types
5385efd chore(package): require node 16.18.0
5ea8b52 chore(README): gitter url to matrix (#4520)
fc260ab fix(input): delete buffer on vim only
02c2542 fix(native): get pathstr by cursor position (#4553)
1c9c72f fix(workspaceFolder): check directory of fsPath (#4566)
b1e5d71 fix(util): check $XDG_CONFIG_HOME before use as data home (#4492)
abdb129 fix(input): bdel term buf (#4608)
c790182 chore(doc): target of diagnosticInfo
5571414 feat(diagnostic): add target to diagnosticInfo (#4642)
e4ffae5 fix(list): scrolling float preview for vim (#4647)
c5a7123 feat(data): allow languageserver.env (#4658)
44898ec fix(format): formatOnSaveTimeout config with scope (#4689)
d432de2 feat(links): only fetch links on documeng changed (#4690)
ed89997 fix: clean unused code (#4710)
4f3b4d9 feat(handler): hasProvider can accept bufnr (#4714)
18152f2 chore(package): update dependencies
bacbe49 refactor(highlighter): highligher.ts to highlighter.ts (#4730)
5423ee0 feat(completion): stop completion when navigate
29065d9 chore(doc): escape coc_status
1d36382 chore(doc): add refactor buffer section
0a2c8b8 fix: ls provider's score is equal to the default one (#4722)
fab97c7 perf: return early in around and buffer source (#4721)
eba04ac fix: autoActiavte to autoActivate, keeped to kept (#4716)
f7545f2 docs: update outdated url (#4717)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Path autocompletion works only once per line
3 participants