Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SchemaProvider::getSelfSubUrl returns URl with and without ending '/' depending on input resource #123

Closed
neomerx opened this issue Mar 28, 2016 · 1 comment
Assignees
Labels
Milestone

Comments

@neomerx
Copy link
Owner

neomerx commented Mar 28, 2016

If resource is given it returns something like '/posts/2' (note no ending '/') but if null given it returns '/posts/' (with ending '/'). This lead to double slashes in URLs for resources without identities e.g. '/profile//relationships/comments'.

Need more consistency. It should be no trailing '/' in all cases.

@neomerx neomerx self-assigned this Mar 28, 2016
@neomerx neomerx added the bug label Mar 28, 2016
@neomerx neomerx added this to the 0.8.0 milestone Mar 28, 2016
@neomerx
Copy link
Owner Author

neomerx commented Mar 28, 2016

It will be a breaking change. Sub-url in Schema (if set) had to have both starting and ending slashes e.g. '/posts/'. Now it must have only starting.

As this feature is optional it won't affect majority of users. Though it must be documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant