Updates for wagtail 2.15 and django 4 compatibility #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have also added the migration files which I had previously missed. Should also fix #18 |
danhayden
changed the title
- changed django.conf.urls.url to django.urls.re_path
|
I've noticed a visual problem when checking out the branch Ideally these shouldn't be stacked, they should be side-by-side with a bit of spacing between |
|
I've pushed a fix and tested on wagtail 2.15.5 and wagtail 3.0 on wagtail 2.15.5:
on wagtail 3.0:
|
|
Awesome work @danhayden, thanks heaps. Noticed one small django 4 problem but I'll fix it up in an upcoming branch. I'll release this in version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in wagtail 2.15 modeladmin templates caused birdsong templates to break visually and prevented the preview iframe from working due to the form selector in preview_campaign.js matching the wrong form on the page.
Fixes #14