Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄 Modernize the appearance of about page and make it responsive. #530

Merged
merged 48 commits into from
Mar 2, 2024

Conversation

cybrejon
Copy link
Contributor

@cybrejon cybrejon commented Feb 20, 2024

What does this PR do?

This PR modifies simple.css to include better padding, margin, alignment and introduce RWD (responsive web design) to the about page.

Preview/Screenshots

Small Screen Devices

127 0 0 1_8080_about

Large Screen Devices

127 0 0 1_8080_about (1)

Why is this change important?

The current about's page is painfully outdated and not mobile-friendly. This hopes to fix that.

Related issues

Closes #433

cybrejon and others added 30 commits November 27, 2023 19:05
Co-authored-by: neon_arch <mustafadhuleb53@gmail.com>
Copy link
Owner

@neon-mmd neon-mmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review.
Thanks ❤️ for working on this PR. We really appreciate it 👍 Keep it up!! but before we merge this PR. We would suggest the following changes. 🙂

public/static/themes/simple.css Outdated Show resolved Hide resolved
Copy link
Owner

@neon-mmd neon-mmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay in the reply.
One last small suggestion, I feel it would be better to have all the media queries at the end of the file so that anyone else working on this future does not get confused or lost when searching/editing media queries. Moreover, I think it would make the code consistent too. What do you think? 🙂

@cybrejon
Copy link
Contributor Author

cybrejon commented Mar 1, 2024

Sorry for the delay in the reply. One last small suggestion, I feel it would be better to have all the media queries at the end of the file so that anyone else working on this future does not get confused or lost when searching/editing media queries. Moreover, I think it would make the code consistent too. What do you think? 🙂

I believe they are already at the bottom-most part of the file.

@neon-mmd
Copy link
Owner

neon-mmd commented Mar 1, 2024

Sorry for the delay in the reply. One last small suggestion, I feel it would be better to have all the media queries at the end of the file so that anyone else working on this future does not get confused or lost when searching/editing media queries. Moreover, I think it would make the code consistent too. What do you think? 🙂

I believe they are already at the bottom-most part of the file.

Ok I see, I am sorry, I think I overlooked it. Thanks ❤️ for pointing it out. 🙂

Copy link
Owner

@neon-mmd neon-mmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ❤️ again for working on this. Since everything looks good. We will merge this PR as soon as possible. 🙂

@neon-mmd neon-mmd merged commit 11d23fd into neon-mmd:rolling Mar 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

💄 Redesign the theme design for the about page
4 participants