Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preparatory pageserver async conversions #4773

Merged
merged 7 commits into from
Jul 24, 2023
Merged

Preparatory pageserver async conversions #4773

merged 7 commits into from
Jul 24, 2023

Conversation

arpad-m
Copy link
Member

@arpad-m arpad-m commented Jul 21, 2023

Problem and change summary

In #4743, we'd like to convert the read path to use async rust. In preparation of that, this PR switches some functions that are calling lower level functions like BlockReader::read_blk, BlockCursor::read_blob, etc into async. The PR does not switch all functions however, and only focuses on the ones which are easy to switch.

This leaves around some async functions that are (currently) unnecessarily async, but on the other hand it makes future changes smaller in diff.

Part of #4743 (but does not completely address it).

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@arpad-m
Add 'static bound to Layer
6265737
@arpad-m
Add #[async_trait::async_trait] to the Layer trait and its implementa…
10c7933 
…tions
@arpad-m
Turn Layer::get_value_reconstruct_data into an async function
4eac659 
Also, convet the call sites. The actual implementation is not
async yet.
@arpad-m
Remove the BlobCursor trait
a34a2b3 
traits add runtime dispatch overhead in async contexts
@arpad-m
Make Layer::dump async
3c608fe 
Some implementations of it call functions internally that we want to
make async in the future.
@arpad-m
Make layers::read_delta_file async
3a6301c
@arpad-m
Make get_holes function async
2a303e7
@arpad-m arpad-m requested a review from problame July 21, 2023 14:43
@arpad-m arpad-m requested review from a team as code owners July 21, 2023 14:43
@arpad-m arpad-m requested review from awestover and removed request for a team July 21, 2023 14:43
@github-actions
Copy link

github-actions bot commented Jul 21, 2023 •
edited
Loading

1040 tests run: 989 passed, 0 failed, 51 skipped (full report)

@koivunej
Copy link
Member

Please do not re-run failed on this PR.

@koivunej
Copy link
Member

koivunej commented Jul 24, 2023 •
edited
Loading

Oki comment error triaged, re-running failed. @bayandin will fix :)

@arpad-m arpad-m merged commit e5b7ddf into main Jul 24, 2023
29 checks passed
@arpad-m arpad-m deleted the arpad/pageserver_io_async branch July 24, 2023 12:01
@arpad-m arpad-m mentioned this pull request Aug 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koivunej koivunej koivunej approved these changes

@problame problame Awaiting requested review from problame

@awestover awestover Awaiting requested review from awestover awestover was automatically assigned from neondatabase/compute

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arpad-m @koivunej