Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix allure report overwriting for different Postgres versions #4806

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

bayandin
Copy link
Member

Problem

We've got an example of Allure reports from 2 different runners for the same build that started to upload at the exact second, making one overwrite another:

Summary of changes

  • Use the Postgres version to distinguish artifacts (along with build type)

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@bayandin bayandin requested a review from koivunej July 25, 2023 13:44
@github-actions
Copy link

1236 tests run: 1184 passed, 0 failed, 52 skipped (full report)


Flaky tests (1)

Postgres 15

  • test_remote_timeline_client_calls_started_metric[local_fs]: release

Copy link
Member

@koivunej koivunej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix seems straightforward :)

@bayandin bayandin merged commit b98419e into main Jul 26, 2023
28 checks passed
@bayandin bayandin deleted the bayandin/fix-allure-report-overwriting branch July 26, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants