Use WebIdentityTokenCredentialsProvider to access remote extensions #4921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubennikovaav
requested review from
koivunej,
a team and
bayandin
and removed request for
a team
koivunej
reviewed
Aug 7, 2023
koivunej
reviewed
Aug 7, 2023
koivunej
reviewed
Aug 7, 2023
1264 tests run: 1211 passed, 0 failed, 53 skipped (full report) |
|
looks awesome! |
|
Created a PR with my suggestions: #4922 |
|
We must next add e2e test that we are able to do these requests because of this new provider. Unsure how to setup such situation, or how to create a webidentity thing for the run. |
Review comments on #4921: - check the WebIdentity provider before imdsv2 because imds will do a http request which will cost more than checking local env variables - move provider config to be nearer to webidentity provider - refactor out the common wrapping of `aws_config::...::Region`
It will be covered by remote extensions e2e test. |
koivunej
approved these changes
Aug 8, 2023
bayandin
reviewed
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes access to s3 buckets that use IAM roles for service accounts access control method