Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI(promote-compatibility-data): take into account commit sha #8283

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

bayandin
Copy link
Member

@bayandin bayandin commented Jul 5, 2024

Problem

In #8161, we changed the path to Neon artefacts by adding commit sha to it but we missed adding these changes to promote-compatibility-data job that we use for backward/forward- compatibility testing.

An example of failed job: https://github.com/neondatabase/neon/actions/runs/9845717109/job/27186681258

Summary of changes

  • Add commit sha to promote-compatibility-data

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Copy link

github-actions bot commented Jul 5, 2024

3092 tests run: 2977 passed, 0 failed, 115 skipped (full report)


Flaky tests (3)

Postgres 14

  • test_change_pageserver: debug
  • test_statvfs_pressure_usage: debug
  • test_pg_regress[4]: debug

Code coverage* (full report)

  • functions: 32.6% (6939 of 21280 functions)
  • lines: 50.0% (54556 of 109068 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
5d8c62f at 2024-07-09T08:48:00.967Z :recycle:

@bayandin bayandin force-pushed the bayandin/fix-promote-compatibility-data branch from 66ec020 to 74baf17 Compare July 8, 2024 21:46
@bayandin bayandin changed the title CI(promote-compatibility-data): debug and fix something CI(promote-compatibility-date): take into account commit sha Jul 8, 2024
@bayandin bayandin marked this pull request as ready for review July 8, 2024 21:49
@bayandin bayandin changed the title CI(promote-compatibility-date): take into account commit sha CI(promote-compatibility-data): take into account commit sha Jul 8, 2024
@bayandin bayandin force-pushed the bayandin/fix-promote-compatibility-data branch from 74baf17 to 5d8c62f Compare July 8, 2024 21:50
@bayandin bayandin requested a review from Bodobolero July 8, 2024 21:52
@bayandin bayandin enabled auto-merge (squash) July 8, 2024 21:53
Copy link
Contributor

@Bodobolero Bodobolero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing my oversight.

@bayandin bayandin merged commit 8b15864 into main Jul 9, 2024
68 checks passed
@bayandin bayandin deleted the bayandin/fix-promote-compatibility-data branch July 9, 2024 08:39
skyzh pushed a commit that referenced this pull request Jul 15, 2024
## Problem

In #8161, we changed the path
to Neon artefacts by adding commit sha to it, but we missed adding these
changes to `promote-compatibility-data` job that we use for
backward/forward- compatibility testing.

## Summary of changes
- Add commit sha to `promote-compatibility-data`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants