Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devx: nicer diff hunk headers #8482

Merged
merged 1 commit into from
Jul 24, 2024
Merged

devx: nicer diff hunk headers #8482

merged 1 commit into from
Jul 24, 2024

Conversation

koivunej
Copy link
Member

By default git does not find a nice hunk header with rust. New(er) versions ship with a handy xfuncname pattern, so lets enable that for all developers.

Example of how this should help: rust-lang/rust@3904617

@koivunej koivunej marked this pull request as ready for review July 24, 2024 10:06
@koivunej koivunej enabled auto-merge (squash) July 24, 2024 10:06
Copy link
Contributor

@conradludgate conradludgate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

before:
Screenshot 2024-07-24 at 11 07 08

after:
Screenshot 2024-07-24 at 11 06 49

LGTM

Copy link

github-actions bot commented Jul 24, 2024

3151 tests run: 3030 passed, 0 failed, 121 skipped (full report)


Flaky tests (1)

Postgres 15

  • test_layer_download_cancelled_by_config_location: debug

Code coverage* (full report)

  • functions: 32.7% (6987 of 21380 functions)
  • lines: 50.1% (55554 of 110857 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
a123f94 at 2024-07-24T14:25:57.513Z :recycle:

Copy link
Member

@bayandin bayandin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@koivunej koivunej merged commit 99b1a1d into main Jul 24, 2024
67 checks passed
@koivunej koivunej deleted the better_hunk_header_for_all branch July 24, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants