Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use debian packages for cmake again #9212

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Conversation

hlinnaka
Copy link
Contributor

@hlinnaka hlinnaka commented Sep 30, 2024

On bookworm, 'cmake' is new enough that we can just use it. On bullseye, we can get a new-enough package from backports. By including 'cmake' in the build-deps stage, we don't need to install it separately in all the later build stages that need it.

See #2699, where we switched to downloading and building a specific version.

On bookworm, 'cmake' is new enough that we can just use it. On
bullseye, we can get a new-enough package from backports. By including
'cmake' in the build-deps stage, we don't need to install it
separately in all the later build stages that need it.

See #2699, where switched to
downloading and building a specific version.
@hlinnaka hlinnaka requested review from bayandin, a-masterov, a team and lubennikovaav and removed request for a team September 30, 2024 22:10
Copy link

github-actions bot commented Sep 30, 2024

5022 tests run: 4864 passed, 0 failed, 158 skipped (full report)


Flaky tests (3)

Postgres 16

Postgres 14

  • test_ondemand_wal_download_in_replication_slot_funcs: release-arm64

Code coverage* (full report)

  • functions: 31.3% (7489 of 23896 functions)
  • lines: 49.6% (60113 of 121251 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
ad83e01 at 2024-10-01T09:00:54.019Z :recycle:

Copy link
Member

@bayandin bayandin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

compute/Dockerfile.compute-node Outdated Show resolved Hide resolved
@hlinnaka hlinnaka merged commit 1b8b507 into main Oct 1, 2024
81 checks passed
@hlinnaka hlinnaka deleted the use-cmake-from-bullseye-backports branch October 1, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants