Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small memory accounting bug in libpagestore #9223

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Conversation

MMeent
Copy link
Contributor

@MMeent MMeent commented Oct 1, 2024

Found while searching for other issues in shared memory.

The bug should be benign, in that it over-allocates memory for this struct, but doesn't allow for out-of-bounds writes.

Problem

We over-allocate memory in libpagestore's shared memory area

Summary of changes

We fix the memory accounting error

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Found while searching for other issues in shared memory.

The bug should be benign, in that it over-allocates memory for this struct, but doesn't allow for out-of-bounds writes.
@MMeent MMeent requested review from a team as code owners October 1, 2024 13:42
@MMeent MMeent requested review from kelvich and arssher October 1, 2024 13:42
@hlinnaka
Copy link
Contributor

hlinnaka commented Oct 1, 2024

fixes #9222

Copy link

github-actions bot commented Oct 1, 2024

5022 tests run: 4864 passed, 0 failed, 158 skipped (full report)


Flaky tests (1)

Postgres 14

Test coverage report is not available

The comment gets automatically updated with the latest test results
35d57f7 at 2024-10-01T16:31:38.383Z :recycle:

@MMeent MMeent enabled auto-merge (squash) October 1, 2024 15:23
@MMeent MMeent merged commit 6efdb1d into main Oct 1, 2024
79 of 80 checks passed
@MMeent MMeent deleted the MMeent-patch-1 branch October 1, 2024 16:38
hlinnaka added a commit that referenced this pull request Oct 1, 2024
hlinnaka added a commit that referenced this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants