Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the size of the perf counters shared memory array #9226

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

hlinnaka
Copy link
Contributor

@hlinnaka hlinnaka commented Oct 1, 2024

MaxBackends doesn't include auxiliary processes. Whenever an aux process made IO operations that updated the counters, they would scribble over shared memory beoynd the end of the array. The relsize cache hash table comes after the array, so the symptom was an error about hash table corruption in the relsize cache hash.

@hlinnaka hlinnaka requested review from a team as code owners October 1, 2024 15:31
@MMeent
Copy link
Contributor

MMeent commented Oct 1, 2024

Note that this needs to be deployed to prod quite quickly as it is a likely cause of bad performance and/or other corruptions.

Copy link

github-actions bot commented Oct 1, 2024

5022 tests run: 4864 passed, 0 failed, 158 skipped (full report)


Flaky tests (3)

Postgres 16

  • test_ondemand_wal_download_in_replication_slot_funcs: release-x86-64

Postgres 15

Postgres 14

Code coverage* (full report)

  • functions: 31.4% (7489 of 23881 functions)
  • lines: 49.6% (60100 of 121224 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
813eaba at 2024-10-01T17:32:17.091Z :recycle:

@hlinnaka
Copy link
Contributor Author

hlinnaka commented Oct 1, 2024

I had to disable the sanity check on v14, because on v14, MyProc isn't initialized until later so the check crashed.

I also included #9223 here.
edit: Never mind, I see you just merged it separately :-)

MaxBackends doesn't include auxiliary processes. Whenever an aux
process made IO operations that updated the counters, they would
scribble over shared memory beoynd the end of the array. The relsize
cache hash table comes after the array, so the symptom was an error
about hash table corruption in the relsize cache hash.
@lubennikovaav lubennikovaav merged commit 8861e8a into main Oct 1, 2024
82 checks passed
@lubennikovaav lubennikovaav deleted the fix-perfcounters-array-size branch October 1, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants