Copy iterator result in BitmapHeapNext #276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MMeent
reviewed
Apr 4, 2023
| } | ||
| else | ||
| node->tbmres = tbmres = tbm_shared_iterate(shared_tbmiterator); | ||
| tbmres = tbm_shared_iterate(shared_tbmiterator); |
There was a problem hiding this comment.
Should we not hold a lock whilst reading from the shared iterator?
There was a problem hiding this comment.
No, this part of iterator is private to the process - it is not in shared memory.
It allows original code to access this data without any locks
MMeent
approved these changes
Apr 6, 2023
MMeent
pushed a commit
that referenced
this pull request
May 11, 2023
tristan957
pushed a commit
that referenced
this pull request
Aug 10, 2023
tristan957
pushed a commit
that referenced
this pull request
Nov 8, 2023
tristan957
pushed a commit
that referenced
this pull request
Nov 8, 2023
tristan957
pushed a commit
that referenced
this pull request
Nov 8, 2023
tristan957
pushed a commit
that referenced
this pull request
Feb 5, 2024
tristan957
pushed a commit
that referenced
this pull request
Feb 5, 2024
tristan957
pushed a commit
that referenced
this pull request
Feb 6, 2024
tristan957
pushed a commit
that referenced
this pull request
May 10, 2024
tristan957
pushed a commit
that referenced
this pull request
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #275