Skip to content
This repository has been archived by the owner on Apr 28, 2024. It is now read-only.

feat(transport): Add websocket transport; #5

Merged
merged 7 commits into from
Jan 1, 2023
Merged

Conversation

salemzii
Copy link
Contributor

@salemzii salemzii commented Dec 27, 2022

This pull request provides support for the WebSocket transport layer; allowing the bi-directional transfer of messages from client to server using an upgraded HTTP connection. Additionally, the Pr includes support for chaining middlewares together, avoiding the need to repeatedly call WithMiddleware(mw Middleware) Option {}

@salemzii salemzii changed the title Support chaining multiple middlewares. feat(transport): Add websocket transport; Dec 28, 2022
Copy link
Owner

@neonxp neonxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thank you for your work! WS transport is a awesome enhancement!

Before I can merge PR I have some comments to code.

transport/websockets.go Outdated Show resolved Hide resolved
transport/websockets.go Outdated Show resolved Hide resolved
transport/websockets.go Outdated Show resolved Hide resolved
transport/websockets.go Outdated Show resolved Hide resolved
transport/websockets.go Outdated Show resolved Hide resolved
transport/websockets.go Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@salemzii
Copy link
Contributor Author

Thanks for the review @neonxp, I will make all the necessary changes ASAP;

@salemzii salemzii requested a review from neonxp December 30, 2022 09:08
@neonxp
Copy link
Owner

neonxp commented Jan 1, 2023

Looks good now! Thank you for your work. I will merge and create release now.

@neonxp neonxp merged commit 2afee24 into neonxp:master Jan 1, 2023
@neonxp
Copy link
Owner

neonxp commented Jan 1, 2023

Here is new release with your PR: v1.3.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants