This repository has been archived by the owner on Apr 28, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 10
feat(transport): Add websocket transport; #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salemzii
changed the title
Support chaining multiple middlewares.
feat(transport): Add websocket transport;
Dec 28, 2022
neonxp
suggested changes
Dec 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello! Thank you for your work! WS transport is a awesome enhancement!
Before I can merge PR I have some comments to code.
Thanks for the review @neonxp, I will make all the necessary changes ASAP; |
Looks good now! Thank you for your work. I will merge and create release now. |
Here is new release with your PR: v1.3.0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request provides support for the WebSocket transport layer; allowing the bi-directional transfer of messages from client to server using an upgraded HTTP connection. Additionally, the Pr includes support for chaining middlewares together, avoiding the need to repeatedly call
WithMiddleware(mw Middleware) Option {}