Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests break with plenary commit dd5a2f6d #3

Open
5 tasks done
laurentS opened this issue Sep 15, 2023 · 0 comments
Open
5 tasks done

Tests break with plenary commit dd5a2f6d #3

laurentS opened this issue Sep 15, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@laurentS
Copy link
Contributor

FAQ

  • I have checked the FAQ and it didn't resolve my problem.

Issues

  • I have checked existing issues and there are no issues with the same problem.

Neovim Version

0.9.2

Dev Version?

  • I am using a stable Neovim release version, or if I am using a dev version of Neovim I have confirmed that my issue is reproducible on a stable version.

Operating System

linux/debian

Minimal Config

Tests break in CI: https://github.com/neovim-stuff/null-ls.nvim/actions/runs/6196647754/job/16823718477?pr=2

bisecting plenary, the cause seems to be this commit: https://github.com/nvim-lua/plenary.nvim/commit/dd5a2f6d677f9c31dc55f0ab1ec2e9e43c408052

Steps to Reproduce

make test

Reproducibility Check

  • I confirm that my minimal config is based on the minimal_init.lua template and that my issue is reproducible by running nvim --clean -u minimal_init.lua and following the steps above.

Expected Behavior

tests should pass

Actual Behavior

they fail :(

Debug Log

Fail    ||      diagnostics handler handler changedtick tracking should call handler only once if buffer changed in between callbacks
      null-ls.nvim/test/spec/diagnostics_spec.lua:132: Expected to be called 1 time(s), but was called 2 time(s)

Help

Yes

Implementation Help

No response

Requirements

  • I have read and followed the instructions above and understand that my issue will be closed if I did not provide the required information.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant