Skip to content

skip <link rel="canonical"> for 404 page #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 15, 2025
Merged

skip <link rel="canonical"> for 404 page #384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ee59b22
Add custom 404 page with Neovim branding
alarcritty Sep 12, 2025
48c357c
refactor: optimize 404 page to use existing CSS utilities
alarcritty Sep 12, 2025
10d3220
refactor: remove custom classes, use existing masthead/lead styles
alarcritty Sep 14, 2025
e4fc6ed
style: restore typewriter style font for 404.
alarcritty Sep 14, 2025
b68409d
refactor: switch to golden-grid, remove bottom margin
alarcritty Sep 14, 2025
6f8e14e
style: update color .masthead
alarcritty Sep 15, 2025
21e7934
feat: add custom 404 page with GitHub Pages permalink support
alarcritty Sep 15, 2025
7fed886
Merge branch 'master' into master
alarcritty Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions 404.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,12 @@
layout: default
title: Page Not Found
canonical_url: /404.html
permalink: /404.html
---
{% include nav.html %}
<main class="front-section">
<div style="padding: 3rem 0; min-height: 60vh; display: flex; align-items: center;">
<div class="container">
<div class="masthead" style="max-width: 600px; margin: 0 auto; background-color: transparent;">
<div class="masthead" style="max-width: 600px; margin: 0 auto; background-color: transparent; text-align: center;">
<div class="lead">404</div>
<h1>Page Not Found</h1>
<p class="light">The page you're looking for doesn't exist. It might have been moved, deleted, or you entered the wrong URL.</p>
Expand All @@ -16,15 +17,14 @@ <h1>Page Not Found</h1>
<a href="/doc/" class="btn">Documentation</a>
</div>
</div>
</div>
</div>
</main>
</div>

<style>
.masthead .lead {
font-size: 8rem;
font-weight: 700;
color:#22C55E;
color: #22C55E;
font-family: 'SF Mono', 'Monaco', 'Inconsolata', 'Roboto Mono', 'Courier New', monospace;
line-height: 1;
margin-bottom: 0.5rem;
Expand All @@ -41,8 +41,10 @@ <h1>Page Not Found</h1>
}

.masthead .flex {
display: flex;
justify-content: center;
flex-wrap: wrap;
gap: 1rem;
}

@media (max-width: 525px) {
Expand All @@ -56,6 +58,7 @@ <h1>Page Not Found</h1>

.masthead p {
font-size: 1.1rem;
margin-bottom: 2rem;
}

.masthead .flex {
Expand All @@ -66,7 +69,11 @@ <h1>Page Not Found</h1>
.masthead .btn {
width: 100%;
max-width: 280px;
text-align: center !important;
display: flex !important;
align-items: center !important;
justify-content: center !important;
padding: 0.75rem 1rem !important;
}
}
</style>

4 changes: 4 additions & 0 deletions _layouts/default.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,11 @@

<link href="/css/main.css" rel="stylesheet">
<link href="/css/neovim-hi.css" rel="stylesheet">
{% unless page.url == "/404.html" %}
<link rel="canonical" href="{{ site.url }}{% if page.canonical_url %}{{ page.canonical_url }}{% else %}{{ page.url }}{% endif %}" />
Comment on lines +26 to 27
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC, the key change is that rel="canonical" is skipped for the 404 page.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, exactly right. That's the core fix - should have highlighted that upfront instead of all the implementation details

{% else %}
<meta name="robots" content="noindex">
{% endunless %}
</head>

<body>
Expand Down