-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
Fix #10386 #15267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Fix #10386 #15267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5204af7
to
16649d5
Compare
Rebase? Also needs a test; simple repro steps given in #10386 |
Should be all good, but for some reason it seems that the test always succeeds. |
…ing used Problem: Crash when a callback deletes a window that is being used. Solution: Do not unload a buffer that is being displayed while redrawing the screen. Also avoid invoking callbacks while redrawing. (closes vim/vim#2107) vim/vim@94f0195 Co-authored-by: Brian Koropoff <@bkoropoff>
Problem: Crash when terminal API call deletes the buffer. Solution: Lock the buffer while calling a function. (closes vim/vim#2813) vim/vim@a997b45
The test changes from patch 8.0.1732 are needed for oldtests to pass. |
Will add them then |
justinmk
reviewed
Jul 5, 2022
dict_T *dict = get_v_event(&save_v_event); | ||
tv_dict_add_nr(dict, S_LEN("status"), status); | ||
tv_dict_set_keys_readonly(dict); | ||
aucmd_prepbuf(&aco, buf); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Continued in #19233 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10386, using vim-patches and help from this commit from @bkropoff.
Include a few vim patches: