fix(api): on_detach consistently before buf_freeall autocmds #34024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seandewar
force-pushed
the
on_detach-sooner
branch
2 times, most recently
from
fd4d829 to
5ba2d12
Compare
seandewar
force-pushed
the
on_detach-sooner
branch
from
5ba2d12 to
e0a9f39
Compare
seandewar
force-pushed
the
on_detach-sooner
branch
from
e0a9f39 to
614a159
Compare
seandewar
changed the title
seandewar
commented
Aug 17, 2025
src/nvim/buffer.c
Outdated
Comment on lines
787
to
791
| // Disable buffer-updates for the current buffer. | ||
| buf_updates_unload(buf, false); | ||
| if (!bufref_valid(&bufref)) { | ||
| // on_detach callback deleted the buffer. | ||
| return; | ||
| } |
There was a problem hiding this comment.
on_detach has textlock set, and like the autocmds below has b_locked set here too. Makes it pretty hard to delete the buffer, but it might still be possible; it's at least consistent with below to include the check.
seandewar
force-pushed
the
on_detach-sooner
branch
3 times, most recently
from
2bc7e43 to
8b7feb8
Compare
Problem: on_detach may be called after buf_freeall and other important things, plus its textlock restrictions are insufficient. This can cause issues such as leaks, internal errors and crashes. Solution: disable buffer updates in buf_freeall, before autocommands (like the order after neovim#35355 and when do_ecmd reloads a buffer). Don't do so in free_buffer_stuff; it's not safe to run user code there, and buf_freeall already runs before then; just free them to avoid leaks if buf_freeall autocommands registered more for some reason. Fixes neovim#28084 Fixes neovim#33967 Fixes neovim#35116
seandewar
force-pushed
the
on_detach-sooner
branch
from
8b7feb8 to
9a47ec9
Compare
seandewar
commented
Aug 17, 2025
| end) | ||
|
|
||
| describe('nvim_buf_attach on_detach', function() | ||
| it('is invoked before unloading buffer', function() |
There was a problem hiding this comment.
My test supersedes this one, so I've removed it (but kept the case when wiping the last listed non-reusable buffer)
justinmk
reviewed
Aug 17, 2025
justinmk
approved these changes
Aug 17, 2025
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: on_detach may be called after buf_freeall and other important
things, plus its textlock restrictions are insufficient. This can cause issues
such as leaks, internal errors and crashes.
Solution: disable buffer updates in buf_freeall, before autocommands (like the
order after #35355 and when do_ecmd reloads a buffer). Don't do so in
free_buffer_stuff; it's not safe to run user code there, and buf_freeall already
runs before then; just free them to avoid leaks if buf_freeall autocommands
registered more for some reason.
Fixes #28084
Fixes #33967
Fixes #35116