Skip to content

Conversation

deathbeam
Copy link
Contributor

  • Move autocmd cleanup logic back to setup_layout as WinClosed autocmds were triggering for every closed window even when buf scoped, and when buf scoped, pattern filter did not work.
  • Cleanup when quickfix window is closed as well to prevent state where on closing quickfix setup_layout will reset it after with empty content because of WinClosed autocmds triggering.

- Move autocmd cleanup logic back to setup_layout as WinClosed autocmds
  were triggering for every closed window even when buf scoped, and when
  buf scoped, pattern filter did not work.
- Cleanup when quickfix window is closed as well to prevent state where
  on closing quickfix setup_layout will reset it after with empty
  content because of WinClosed autocmds triggering.

Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
@justinmk
Copy link
Member

It's usually a sign of a design issue when buffer-local autocmds aren't used. But I can't look at this closely to give specific advice.

@justinmk justinmk merged commit aaec3e5 into neovim:master Oct 13, 2025
39 checks passed
@deathbeam deathbeam deleted the difftool-cleanup-fix branch October 13, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants