append ".cmd" to command arg0 if it fails on Windows

[justinmk]

Problem

Commonly on Windows, some commands require the .cmd suffix. This is often missed, leading to issues like #2032 , and the solution is copy-pasted into configs: #2039

Proposal

@williamboman #2032 (comment) :

exepath() seems to solve this pretty nicely, as Neovim does respect PATHEXT. null-ls uses it and mason-lspconfig.nvim successfully patches cmds with it. I'd be happy to open a PR that patches commands with exepath() on Windows + normalizes all commands in server configs.

Or is there a reason why we don't use vim.fn.system() (which should do this automatically) instead of uv_spawn (vim.loop.spawn))? (Probably the reason is: that doesn't work in Lua "fast" callbacks)

[glepnir]

I don't check the system c code but can we do it like system{fast=true} a little change ?

[justinmk]

possibly.

[glepnir]

Probably the reason is: that doesn't work in Lua "fast" callbacks

yup it not work in event loop unless we set {fast=true} .

[acfuns]

What is the current state？
On windows, mason download LSP is completely unavailable at all.

[williamboman]

What is the current state？
On windows, mason download LSP is completely unavailable at all.

I'd recommend using https://github.com/williamboman/mason-lspconfig.nvim if you're on Windows. It patches the commands for you automatically.

[GersiD]

This would be such a terrific addition! I just tore my hair out with this error! An lsp was erroring out because the language server command did not exist, I make sure to add it to the path, and still no dice. Once I added the .cmd to the end of the lsp start command it magically worked. Thank you so much for noticing! It makes me incredibly happy that I was not the only one with this issue.