Revert "fix: vim.eval('v:true') should return python bool #506" #562
Conversation
|
The checks are failing even without the changes that I made (when the fork is identical to the current upstream) (https://github.com/samuelqp/pynvim/actions/runs/8304465825). |
|
Thanks for the PR! The tests are broken because they refer to a (internal) function that was removed in neovim/neovim@eb5d15e |
|
Thanks! Seems good now. |
|
One more ask: can you add a "Known issues" section after this section which explains this quirk? So that we don't get repeat reports of #506 |
Done |
| assert h.legacy_vim.eval('1') == '1' | ||
| assert h.legacy_vim.eval('v:null') is None | ||
| assert h.legacy_vim.eval('v:true') is True | ||
| assert h.legacy_vim.eval('v:false') is False |
There was a problem hiding this comment.
Aren't these tests still useful? Could change the expected values.
Changes since 0.5.0: - 4813ce6 fix(tests): failing tests on python3.13 about stacktrace messages #578 - 9391eff docs: avoid deprecated $NVIM_LISTEN_ADDRESS env var #575 - 9fc77f0 fix(tests): remove reference to pytest-runner #573 - a855fa3 fix: deprecated alias of logger.warn #569 - cc45f5b fix(tests): broadcast test fails #570 - 4d65226 fix(ci): macOS CI fails with "Unrecognized archive format" - d6dc8cf fix: UpdateRemotePlugins not finding specs on Windows #565 - 9f3e010 Revert "fix: vim.eval('v:true') should return python bool" #562 - f9d839f fix(tests): "provider#python3#Prog" was removed upstream #563 - 5f989df refactor: remove the use of forward references #558 - c4197f1 fix(ci): failing readthedocs build #554 - da0970e ci: fix failing readthedocs build - 7a84048 fix(ci): failing readthedocs build #553 - e74a7f6 test: attaching via socket, tcp, stdio #544 - 17fbcbc fix: prevent closed pipe errors on closing asyncio transport resources - 7f60f72 refactor: improve typing - 3f5f532 refactor: separate asyncio Protocol from AsyncioEventLoop - 2059684 refactor: use async coroutine and add debugging statements - be5810b refactor: expose event loop as a property rather than a field - a1347ee refactor!: completely wipe out pyuv
This reverts commit d549371. This fixes #523 and make UltiSnips usable. As mentioned by @jsr-p, the extra check is redundant and is not worth the slower performance.