Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix schemaorg_description not being in Meta class #164

Conversation

protoroto
Copy link
Member

Description

Fix schemaorg_description not being in Meta class

References

Fix #127

Checklist

  • I have read the contribution guide
  • Code lint checked via inv lint
  • changes file included (see docs)
  • Usage documentation added in case of new features
  • Tests added

@protoroto protoroto requested a review from yakky August 9, 2023 14:18
@coveralls
Copy link

coveralls commented Aug 9, 2023

Coverage Status

coverage: 98.261% (+0.02%) from 98.246% when pulling 913c9b6 on protoroto:bugfix/issue-127-fix-schemaorg-description into 3dce2ff on nephila:develop.

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02% 🎉

Comparison is base (3dce2ff) 97.58% compared to head (913c9b6) 97.60%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #164      +/-   ##
===========================================
+ Coverage    97.58%   97.60%   +0.02%     
===========================================
  Files            8        8              
  Lines          456      460       +4     
  Branches        78       78              
===========================================
+ Hits           445      449       +4     
  Misses           8        8              
  Partials         3        3              
Flag Coverage Δ
unittests 97.39% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
meta/views.py 98.13% <100.00%> (+0.03%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@protoroto protoroto merged commit ce4e28f into nephila:develop Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

schemaorg_description Exception
3 participants