Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add schema.org support #166

Merged
merged 6 commits into from
Sep 25, 2023
Merged

Conversation

protoroto
Copy link
Member

@protoroto protoroto commented Aug 25, 2023

Description

Original PR: #76

References

Fix #73

Checklist

  • I have read the contribution guide
  • Code lint checked via inv lint
  • changes file included (see docs)
  • Usage documentation added in case of new features
  • Tests added

@coveralls
Copy link

coveralls commented Aug 25, 2023

Coverage Status

coverage: 98.905% (+0.6%) from 98.272% when pulling 257fd9a on protoroto:feature/76-schema.org into 65c3d5b on nephila:develop.

@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Patch coverage: 81.20% and project coverage change: -4.06% ⚠️

Comparison is base (65c3d5b) 97.62% compared to head (4f3fb10) 93.57%.

❗ Current head 4f3fb10 differs from pull request most recent head 257fd9a. Consider uploading reports for the commit 257fd9a to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #166      +/-   ##
===========================================
- Coverage    97.62%   93.57%   -4.06%     
===========================================
  Files            8        8              
  Lines          463      560      +97     
  Branches        79      101      +22     
===========================================
+ Hits           452      524      +72     
- Misses           8       26      +18     
- Partials         3       10       +7     
Flag Coverage Δ
unittests 93.39% <81.20%> (-4.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
meta/models.py 82.72% <64.10%> (-11.25%) ⬇️
meta/views.py 94.71% <88.17%> (-3.43%) ⬇️
meta/settings.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@protoroto protoroto force-pushed the feature/76-schema.org branch 2 times, most recently from 0421e52 to e11a495 Compare August 28, 2023 07:36
@protoroto protoroto force-pushed the feature/76-schema.org branch 7 times, most recently from 5c92046 to d8b15fb Compare August 28, 2023 13:47
@protoroto protoroto requested a review from yakky August 28, 2023 13:48
@protoroto protoroto changed the title WIP:Add schema.org support Add schema.org support Aug 28, 2023
@protoroto protoroto force-pushed the feature/76-schema.org branch 2 times, most recently from af51ae9 to ce623e9 Compare August 30, 2023 14:01
@protoroto protoroto force-pushed the feature/76-schema.org branch from bb9efe4 to 257fd9a Compare September 22, 2023 16:16
@protoroto protoroto merged commit f294c81 into nephila:develop Sep 25, 2023
@protoroto protoroto mentioned this pull request Sep 25, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improved / generic schema.org support
3 participants