Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unnecessary else statements. #180

Closed
wants to merge 1 commit into from
Closed

Removed unnecessary else statements. #180

wants to merge 1 commit into from

Conversation

thesayfulla
Copy link
Contributor

Description

Hello. I have removed unnecessary "else" statements. Please check my PR. Thank you!

References

Provide any github issue fixed (as in Fix #XYZ)

Checklist

  • I have read the contribution guide
  • Code lint checked via inv lint
  • changes file included (see docs)
  • Usage documentation added in case of new features
  • Tests added

@coveralls
Copy link

coveralls commented Oct 9, 2023

Coverage Status

coverage: 98.905%. remained the same when pulling c11a0e0 on thesayfulla:feature/removed_else_statements into 46583ef on nephila:develop.

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (46583ef) 97.81% compared to head (c11a0e0) 97.81%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #180   +/-   ##
========================================
  Coverage    97.81%   97.81%           
========================================
  Files            8        8           
  Lines          548      548           
  Branches        99       99           
========================================
  Hits           536      536           
  Misses           6        6           
  Partials         6        6           
Flag Coverage Δ
unittests 97.62% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
meta/models.py 94.89% <100.00%> (ø)
meta/views.py 98.23% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@protoroto
Copy link
Member

Hi! Thanks for this pr! :) In order to be able to merge it, we need a couple of things:

  • you should open an issue (something like "Remove useless else statements", and mark it as "Feature request"
  • rename your branch like stated in the contribution guidelines (like feature/issue-<number-of-the-issue-you-opened>-remove-useless-else-statements
  • add a new file in the changes directory named <number-of-the-issue-you-opened>.feature with the commit message as content

All these passages are needed for the CI to pass, and for us to include easily your change in next release.
Feel free to ask questions if I've not explained myself or if you need more info.
Thanks again!

@thesayfulla
Copy link
Contributor Author

Hi! Thanks for this pr! :) In order to be able to merge it, we need a couple of things:

  • you should open an issue (something like "Remove useless else statements", and mark it as "Feature request"
  • rename your branch like stated in the contribution guidelines (like feature/issue-<number-of-the-issue-you-opened>-remove-useless-else-statements
  • add a new file in the changes directory named <number-of-the-issue-you-opened>.feature with the commit message as content

All these passages are needed for the CI to pass, and for us to include easily your change in next release. Feel free to ask questions if I've not explained myself or if you need more info. Thanks again!

Thank you for replying :)

I will do it.

@thesayfulla thesayfulla deleted the feature/removed_else_statements branch October 10, 2023 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants