Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor FullUrlMixin get_domain to handle django.contrib.sites not in INSTALLED_APPS #194

Merged

Conversation

protoroto
Copy link
Member

Description

Refactor FullUrlMixin get_domain to handle django.contrib.sites not in INSTALLED_APPS

References

Fix #192

Checklist

  • I have read the contribution guide
  • Code lint checked via inv lint
  • changes file included (see docs)
  • Usage documentation added in case of new features
  • Tests added

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1a4de31) 97.81% compared to head (6eb7b64) 98.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #194      +/-   ##
===========================================
+ Coverage    97.81%   98.00%   +0.19%     
===========================================
  Files            8        8              
  Lines          548      552       +4     
  Branches        99       98       -1     
===========================================
+ Hits           536      541       +5     
  Misses           6        6              
+ Partials         6        5       -1     
Flag Coverage Δ
unittests 97.82% <100.00%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Dec 13, 2023

Coverage Status

coverage: 98.913% (+0.008%) from 98.905%
when pulling 6eb7b64 on bugfix/issue-192-refactor-fullurlmixin-get-domain
into 1a4de31 on develop.

@protoroto protoroto force-pushed the bugfix/issue-192-refactor-fullurlmixin-get-domain branch from 1671d30 to 6eb7b64 Compare December 13, 2023 13:01
@protoroto protoroto requested a review from yakky December 13, 2023 13:07
@protoroto protoroto merged commit d2a658d into develop Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Undocumented: requires Sites app to be installed
3 participants