Skip to content

Fix repr error on History object #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2019
Merged

Fix repr error on History object #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion taiga/models/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,10 @@ def parse(cls, requester, entry):
return cls(requester, **entry)

def __repr__(self):
return '{0}({1})'.format(self.__class__.__name__, self.id)
try:
return '{0}({1})'.format(self.__class__.__name__, self.id)
except AttributeError:
return '{0}({1})'.format(self.__class__.__name__, id(self))

def __str__(self):
return self._rp()
Expand Down
10 changes: 10 additions & 0 deletions tests/test_history.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,16 @@

class TestHistory(unittest.TestCase):

@patch('taiga.requestmaker.RequestMaker.get')
def test_history_repr(self, mock_requestmaker_get):
mock_requestmaker_get.return_value = MockResponse(
200,
create_mock_json('tests/resources/history_success.json')
)
api = TaigaAPI(token='f4k3')
api.history.issue.get(1)
self.assertTrue('History' in str(api.history))

@patch('taiga.requestmaker.RequestMaker.get')
def test_issue(self, mock_requestmaker_get):
mock_requestmaker_get.return_value = MockResponse(
Expand Down