Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed hidden code outputs #129

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Conversation

lovesprung
Copy link
Contributor

Copy link
Contributor

nephio-prow bot commented May 30, 2024

Hi @lovesprung. Thanks for your PR.

I'm waiting for a nephio-project member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

netlify bot commented May 30, 2024

Deploy Preview for nephio ready!

Name Link
🔨 Latest commit b44aa6b
🔍 Latest deploy log https://app.netlify.com/sites/nephio/deploys/666aa350adc35f000874f20e
😎 Deploy Preview https://deploy-preview-129--nephio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lovesprung
Copy link
Contributor Author

What does the "invalid-commit-message" tag mean? What should I change/add?

@CsatariGergely
Copy link
Contributor

CsatariGergely commented May 30, 2024

I'm working on fixing the build here #130

@radoslawc
Copy link
Contributor

Hi @lovesprung

Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages.

If you accidentally used fixes #NNNN or @-mention, you need to rewrite the git history
of your branch to remove the do-not-merge/invalid-commit-message label.
See Rewriting History.

Signed-off-by: Schweier Dominika <dominika.schweier@nokia.com>
@lovesprung
Copy link
Contributor Author

Thanks @radoslawc , it's fixed now :)

@CsatariGergely
Copy link
Contributor

/assign @efiacor @liamfallon

@liamfallon
Copy link
Member

/ok-to-test

@efiacor efiacor added the documentation Improvements or additions to documentation label Jun 6, 2024
@efiacor
Copy link
Contributor

efiacor commented Jun 6, 2024

/retest

@lovesprung
Copy link
Contributor Author

@liamfallon @efiacor the build is fixed, please check.

@efiacor
Copy link
Contributor

efiacor commented Jun 13, 2024

/approve

@nephio-prow nephio-prow bot added the approved label Jun 13, 2024
@liamfallon
Copy link
Member

/approve
/lgtm

@nephio-prow nephio-prow bot added the lgtm label Jun 17, 2024
Copy link
Contributor

nephio-prow bot commented Jun 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: efiacor, liamfallon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot merged commit 0f95475 into nephio-project:main Jun 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved documentation Improvements or additions to documentation lgtm ok-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs]: Important details are hidden in the documentation
5 participants