Skip to content

Conversation

vjayaramrh
Copy link
Contributor

@vjayaramrh vjayaramrh commented Feb 19, 2025

This Pull Requests provides step by step instructions to create a cluster using the provisioningrequest CRD.

@vjayaramrh vjayaramrh requested review from CsatariGergely, efiacor and gvbalaji and removed request for johnbelamaric and efiacor February 19, 2025 04:16
Copy link

netlify bot commented Feb 19, 2025

Deploy Preview for nephio ready!

Name Link
🔨 Latest commit 3bc448c
🔍 Latest deploy log https://app.netlify.com/sites/nephio/deploys/67b646a24ff90d00085ffdbe
😎 Deploy Preview https://deploy-preview-209--nephio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@dkosteck dkosteck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vjayaramrh Just a couple small formatting suggestions and a couple small questions, overall I think it's good

Co-authored-by: Daniel Kostecki <84861140+dkosteck@users.noreply.github.com>
@arora-sagar
Copy link
Contributor

arora-sagar commented Feb 19, 2025

Looks good. Can you add the description in the PR?

Once the comments are addressed then I will approve.

@nephio-prow nephio-prow bot added the approved label Feb 19, 2025
@vjayaramrh
Copy link
Contributor Author

Looks good. Can you add the description in the PR?

Once the comments are addressed then I will approve.

Done

@nephio-prow nephio-prow bot removed the approved label Feb 19, 2025
vjayaramrh and others added 2 commits February 19, 2025 14:59
Co-authored-by: Gergely Csatari <gergely.csatari@nokia.com>
…e-4-o2ims.md

Co-authored-by: Gergely Csatari <gergely.csatari@nokia.com>
@arora-sagar
Copy link
Contributor

/approve

@nephio-prow nephio-prow bot added the approved label Feb 20, 2025
@gvbalaji
Copy link
Contributor

/approve
/lgtm

Copy link
Contributor

nephio-prow bot commented Feb 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arora-sagar, dkosteck, gvbalaji

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot merged commit db92db9 into nephio-project:main Feb 20, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants