Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GCP instructions to use CC #64

Merged
merged 7 commits into from
Nov 15, 2023

Conversation

johnbelamaric
Copy link
Member

@johnbelamaric johnbelamaric commented Sep 11, 2023

@nephio-prow nephio-prow bot requested review from s3wong and tliron September 11, 2023 20:37
@johnbelamaric
Copy link
Member Author

/hold

work in progress

@johnbelamaric
Copy link
Member Author

/hold cancel

Copy link
Contributor

@vjayaramrh vjayaramrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@nephio-prow nephio-prow bot removed the lgtm label Nov 15, 2023
Copy link
Contributor

nephio-prow bot commented Nov 15, 2023

New changes are detected. LGTM label has been removed.

@johnbelamaric
Copy link
Member Author

/approve

Copy link
Contributor

nephio-prow bot commented Nov 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnbelamaric, vjayaramrh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Nov 15, 2023
@johnbelamaric johnbelamaric merged commit 5a4b2e6 into nephio-project:main Nov 15, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants