-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating docs for R2 #85
Conversation
- Installation guide for GCE - Exercises for OAI and Free5GC
Skipping CI for Draft Pull Request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @arora-sagar,
Looks good. My only concern is that there is a lot or duplication here. The main diff I see is the cluster provisioning and the nf deploy. I think the main purpose of the orig guide was to show the diff ways to deploy a pkg. ie kpt vs PV/PVS vs UI. I think we should keep that common to both use cases. Maybe in a separate section/file?
@efiacor I don't really get it how you want to do that? |
We prob should break some of the exercise steps into their own sections/files and reuse them. Say for instance the "inter-cluster networking" is common to both. |
|
||
## Introduction | ||
|
||
Be sure you have followed the [installation guide]({{< ref "docs/guides/install-guides ">}}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure to render/preview the links etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About the links I am not sure it is like this in the current exercise.md in main
too. @CsatariGergely is it suppose to be like this?
@efiacor Actually that section is not common either. Making the workload cluster in both of them is different the topology is different and the networking is also different. Both exercises don't share the network, network topology right now is in dedicated sub-folders. That is the reason I am using the export commands to use the right path. |
Ye maybe not the best example as the networking is all a bit hacky. But say for instance, these files are identical - https://github.com/nephio-project/test-infra/blob/main/e2e/tests/free5gc/clab-topo.gotmpl We may need to revisit this later. I'll ignore the duplication for now.. 😄 |
@@ -100,9 +100,9 @@ sudo netplan apply | |||
Log onto your VM and run the following command: | |||
|
|||
```bash | |||
wget -O - https://raw.githubusercontent.com/nephio-project/test-infra/v1.0.1/e2e/provision/init.sh | \ | |||
wget -O - https://raw.githubusercontent.com/nephio-project/test-infra/v2.0.0/e2e/provision/init.sh | \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also this one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the issue here is v2.0.0 tag doesn't exist. The documentation is released before the tag is released.
@arora-sagar Cna you just check the links, it could be something with my setup that they are not working as I'm not using GCE so I'm just checking the links on my local machine. |
The tag v2.0.0 tag mentioned in the document doesn't exist for the moment. The documentation is released before the tag is released. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CsatariGergely, liamfallon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Updating documentation for release 2