Common dependencies #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @tliron @electrocucaracha @lapentad |
|
/lgtm |
CsatariGergely
approved these changes
Jan 24, 2024
|
/lgtm |
efiacor
suggested changes
Jan 26, 2024
|
/approve |
| kpt fn render porch-dev | ||
| kpt live init porch-dev | ||
| kpt live apply porch-dev --reconcile-timeout=15m --output=table | ||
| kpt pkg get --for-deployment https://github.com/nephio-project/catalog/nephio/core/porch@main |
There was a problem hiding this comment.
Suggested change
| kpt pkg get --for-deployment https://github.com/nephio-project/catalog/nephio/core/porch@main | |
| kpt pkg get --for-deployment https://github.com/nephio-project/catalog.git/nephio/core/porch@main |
liamfallon
force-pushed
the
common-dependencies
branch
from
ada8908
to
34112a6
Compare
Co-authored-by: Victor Morales <chipahuac@hotmail.com>
Co-authored-by: Victor Morales <chipahuac@hotmail.com>
Co-authored-by: Victor Morales <chipahuac@hotmail.com>
Co-authored-by: Victor Morales <chipahuac@hotmail.com>
Co-authored-by: Victor Morales <chipahuac@hotmail.com>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CsatariGergely, efiacor, lapentad The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update URLs for KPT packages to point at catalog packages and replaced the tag with
@main, added a note to instruct people to replace the@maintag with whatever tag they want to pull