Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2 I18n::InvalidLocale if de is not an available locale #3

Merged
merged 3 commits into from
Apr 7, 2022
Merged

#2 I18n::InvalidLocale if de is not an available locale #3

merged 3 commits into from
Apr 7, 2022

Conversation

Adeynack
Copy link
Contributor

@Adeynack Adeynack commented Apr 2, 2022 •
edited
Loading

fixes #2

@Adeynack Adeynack marked this pull request as ready for review April 3, 2022 14:07
@Adeynack Adeynack requested a review from JensRavens April 3, 2022 14:07
JensRavens
JensRavens requested changes Apr 5, 2022
View reviewed changes
lib/shimmer/utils/localizable.rb Outdated Show resolved Hide resolved
@Adeynack Adeynack requested a review from JensRavens April 6, 2022 08:40
@Adeynack Adeynack merged commit ac94a74 into main Apr 7, 2022
@Adeynack Adeynack deleted the feature/2_i18n_invalidlocale_if_de_is_not_an_available_locale branch April 7, 2022 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JensRavens JensRavens JensRavens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

I18n::InvalidLocale if de is not an available locale
2 participants
@Adeynack @JensRavens