Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure the build directory exists. #319

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Make sure the build directory exists. #319

merged 1 commit into from
Aug 7, 2024

Conversation

keunhong
Copy link
Contributor

@keunhong keunhong commented Aug 7, 2024

Needed with work with the TORCH_EXTENSIONS_DIR environment variable.

@keunhong
Make sure the build directory exists.
dcaf14b 
Needed with work with the `TORCH_EXTENSIONS_DIR` environment variable.
@keunhong keunhong marked this pull request as ready for review August 7, 2024 07:42
liruilong940607
liruilong940607 approved these changes Aug 7, 2024
View reviewed changes
Copy link
Collaborator

@liruilong940607 liruilong940607 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks Keunhong!

@liruilong940607 liruilong940607 merged commit a991bb8 into nerfstudio-project:main Aug 7, 2024
2 checks passed
@keunhong keunhong deleted the make-sure-build-directory-exists branch August 10, 2024 00:20
@brentyi brentyi mentioned this pull request Aug 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liruilong940607 liruilong940607 liruilong940607 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keunhong @liruilong940607