-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: expand nonce to 128-bit #1666
feat: expand nonce to 128-bit #1666
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hold as requested by @zhangsoledad.
Unhold as requested by @zhangsoledad.
01cfd31
to
6f239cc
Compare
@@ -675,11 +675,11 @@ mod tests { | |||
let num = 200; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let num = 200u128;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this doesn't help,
these tests will also take the num
as BlockNumber
, cast can't be avoided.
fn insert_block(
chain_controller: &ChainController,
shared: &Shared,
nonce: u128,
number: BlockNumber,
)
6f239cc
to
62eaab7
Compare
bors r+ |
Build succeeded
|
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub.
git fetch
# Create new working tree.
git worktree add .worktrees/backport rc/v0.22
# Navigate to the new directory.
cd .worktrees/backport
# Cherry-pick all the commits of this pull request and resolve the likely conflicts.
git cherry-pick 017afeacdbfddad8dfda2650cd543e74c7ab9d7c 62eaab7bed92987357a62c6c0e4f75534b57e20f
# Create a new branch with these backported commits.
git checkout -b backport-1666-to-rc/v0.22
# Push it to GitHub.
git push --set-upstream origin backport-1666-to-rc/v0.22
# Go back to the original working tree.
cd ../..
# Delete the working tree.
git worktree remove .worktrees/backport Then, create a pull request where the |
breaking change