Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update for batch variable rename #264

Closed
doitian opened this issue Apr 24, 2019 · 1 comment
Closed

update for batch variable rename #264

doitian opened this issue Apr 24, 2019 · 1 comment
Assignees
@ashchan
Labels
m:sdk

Comments

@doitian
Copy link
Member

doitian commented Apr 24, 2019 •
edited by ashchan
Loading

nervosnetwork/ckb#533

Block:

commit_transactions -> transactions
proposal_transactions -> proposals

Header:

txs_commit -> transactions_root
txs_proposal -> proposals_root

OutPoint:

hash -> tx_hash

CellInput:

valid_since -> since

Script:

binary_hash -> code_hash

Note: CKB has a bug that RPC types still have hash from OutPoint instead of tx_hash.
@Keith-CY Keith-CY mentioned this issue Apr 25, 2019
Merged
@ashchan ashchan added the m:sdk label Apr 25, 2019
@ashchan
Copy link
Contributor

ashchan commented Apr 25, 2019

Remaining OutPoint.hash -> OutPoint.tx_hash fix/update:

https://github.com/nervosnetwork/ckb/blob/develop/util/jsonrpc-types/src/blockchain.rs#L93

@ashchan ashchan closed this as completed May 9, 2019
github-merge-queue bot pushed a commit that referenced this issue Nov 16, 2023
@Keith-CY @renovate
Bump dependencies (#2824)
7a11fb9 
* chore(deps): update dependency lint-staged to v13.3.0

* chore(deps): update babel monorepo to v7.22.15

* chore(deps): update dependency @types/react to v17.0.65

* chore(deps): update dependency concurrently to v8.2.1

* chore(deps): update dependency webpack to v5.88.2

* chore(deps): update dependency @babel/core to v7.22.17

* chore(deps): update dependency @types/styled-components to v5.1.27

* chore(deps): update babel monorepo to v7.23.2 (#264)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @ckb-lumos/bi to v0.20.0 (#265)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @ckb-lumos/base to v0.20.0 (#263)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Chen Yu <keithwhisper@gmail.com>

* chore(deps): update dependency @types/leveldown to v4.0.4 (#258)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency @types/elliptic to v6.4.15 (#269)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency @types/async to v3.2.21 (#267)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ashchan ashchan

Labels
m:sdk
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ashchan @doitian