Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Fennel to version 1.0.0. #1708

Merged
merged 1 commit into from
Nov 28, 2021
Merged

Conversation

technomancy
Copy link
Contributor

This updates Fennel to the latest stable release, 1.0.0: https://fennel-lang.org/v1.0.0/#section

Note that our intent is that this is the last Fennel release ever to contain intentionally breaking changes, other than for potential security issues. We also expect to slow down on development of the language and focus more on ecosystem stuff after this, so I should be pestering you with fewer PRs like this in the future. =)

I have tested this with all known Fennel TIC-80 games. I found two problems.

One of them is that Amethyst Waters has a graphical glitch:

amethyst-glitch

The other is that the player sprites in Butterfly Effect are not rendered: https://alloy-d.itch.io/butterfly-effect In particular the calls to spr from the draw-player function appear to have no effect.

However, both these bugs also manifest on the current git build from before this patch is applied, so they do not seem to be related to the upgrade to Fennel 1.0.0.

Copy link
Owner

@nesbox nesbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you.
I'll check these games later.

@nesbox nesbox merged commit 10d1255 into nesbox:master Nov 28, 2021
@nesbox nesbox mentioned this pull request Nov 28, 2021
@technomancy technomancy deleted the fennel-1.0 branch November 28, 2021 17:40
@technomancy
Copy link
Contributor Author

technomancy commented Nov 28, 2021

Thanks for merging this.

I went back to check and it seems that the Amethyst Waters bug is a duplicate of #1687; going back to the previous commit as the one mentioned there makes the problem disappear, so that one at least is covered.

The other issue was caused by #1508 so I can open a separate issue about that. Edit: just saw that you already opened an issue for them so I will post this info there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants