Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to allow installation with Python 3.8 #1340

Merged
merged 8 commits into from
Nov 24, 2019

Conversation

steffengraber
Copy link
Contributor

This is a fix to allow installation with python 3.8.
After building NEST with python 3.8, an import nest returns
the following error.

Traceback (most recent call last):
  File "nest-simulator_1574171714961/test_tmp/run_test.py", line 2, in <module>
    import nest
  File "nest-simulator_1574171714961/lib/python3.8/site-packages/nest/__init__.py", line 30, in <module>
    from .hl_api import *      # noqa
  File "nest-simulator_1574171714961/lib/python3.8/site-packages/nest/hl_api.py", line 40, in <module>
    _il.import_libs(__file__, globals(), 'lib', ignore=_ignore_modules)
  File "nest-simulator_1574171714961/lib/python3.8/site-packages/nest/import_libs.py", line 73, in import_libs
    code = compile(module, mod_file, 'exec')
TypeError: required field "type_ignores" missing from Module

There is a further explanation here:
https://bugs.python.org/issue35894

@steffengraber
Copy link
Contributor Author

This PR fixes #1337.

Copy link
Contributor

@heplesser heplesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@steffengraber Thank you for the fix! I have a few small comments in the code.

pynest/nest/tests/test_sp/test_growth_curves.py Outdated Show resolved Hide resolved
@terhorstd terhorstd added ZC: PyNEST DO NOT USE THIS LABEL I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) ZP: PR Created DO NOT USE THIS LABEL S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. labels Nov 21, 2019
@jougs jougs requested a review from heplesser November 24, 2019 12:18
@stinebuu stinebuu changed the title Fix to allow installation with python 3.8 Fix to allow installation with Python 3.8 Nov 24, 2019
@stinebuu stinebuu merged commit 9cca04f into nest:master Nov 24, 2019
AliceGem added a commit to dbbs-lab/bsb-daint that referenced this pull request Sep 15, 2020
@steffengraber steffengraber deleted the fix-issue-1337 branch September 6, 2023 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. ZC: PyNEST DO NOT USE THIS LABEL ZP: PR Created DO NOT USE THIS LABEL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants