New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use absolute path for compile-time NEST_PREFIX (cf. #749) #783

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@muffgaga
Contributor

muffgaga commented Jul 10, 2017

As I mentioned in #749, the CMAKE_INSTALL_PREFIX:PATH should be automatically canonicalized to a absolute path (using realpath or similar). This patch introduces a new define CMAKE_NEST_PREFIX which contains the realpath-canonicalized CMAKE_INSTALL_PREFIX.

@gtrensch

This comment has been minimized.

Show comment
Hide comment
@gtrensch

gtrensch Jul 24, 2017

Contributor

Thanks for this contribution! Pull request approved.

Just one comment: You issued the pull request from your master. This may lead to some difficulties. Please see issue #13 "Don't work on your master" for details.

Contributor

gtrensch commented Jul 24, 2017

Thanks for this contribution! Pull request approved.

Just one comment: You issued the pull request from your master. This may lead to some difficulties. Please see issue #13 "Don't work on your master" for details.

@muffgaga

This comment has been minimized.

Show comment
Hide comment
@muffgaga

muffgaga Aug 2, 2017

Contributor

I created a new PR on a new topic branch (based on the current upstream master) → #796

Contributor

muffgaga commented Aug 2, 2017

I created a new PR on a new topic branch (based on the current upstream master) → #796

@heplesser

This comment has been minimized.

Show comment
Hide comment
@heplesser

heplesser Aug 2, 2017

Contributor

Closing this PR since it has been replaced by #796.

Contributor

heplesser commented Aug 2, 2017

Closing this PR since it has been replaced by #796.

@heplesser heplesser closed this Aug 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment