Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use absolute path for compile-time NEST_PREFIX (cf. #749) #783

Closed
wants to merge 1 commit into from
Closed

Use absolute path for compile-time NEST_PREFIX (cf. #749) #783

wants to merge 1 commit into from

Conversation

muffgaga
Copy link
Contributor

As I mentioned in #749, the CMAKE_INSTALL_PREFIX:PATH should be automatically canonicalized to a absolute path (using realpath or similar). This patch introduces a new define CMAKE_NEST_PREFIX which contains the realpath-canonicalized CMAKE_INSTALL_PREFIX.

@muffgaga muffgaga mentioned this pull request Jul 10, 2017
Closed
@terhorstd terhorstd requested a review from jougs July 10, 2017 10:09
@terhorstd terhorstd added ZC: Installation DO NOT USE THIS LABEL I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) ZP: PR Created DO NOT USE THIS LABEL S: Normal Handle this with default priority T: Enhancement New functionality, model or documentation labels Jul 24, 2017
@terhorstd terhorstd requested a review from gtrensch July 24, 2017 09:55
@gtrensch
Copy link
Contributor

Thanks for this contribution! Pull request approved.

Just one comment: You issued the pull request from your master. This may lead to some difficulties. Please see issue #13 "Don't work on your master" for details.

@muffgaga muffgaga mentioned this pull request Aug 2, 2017
Merged
@muffgaga
Copy link
Contributor Author

muffgaga commented Aug 2, 2017

I created a new PR on a new topic branch (based on the current upstream master) → #796

@heplesser
Copy link
Contributor

Closing this PR since it has been replaced by #796.

@heplesser heplesser closed this Aug 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtrensch gtrensch gtrensch approved these changes

@jougs jougs Awaiting requested review from jougs

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Enhancement New functionality, model or documentation ZC: Installation DO NOT USE THIS LABEL ZP: PR Created DO NOT USE THIS LABEL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@muffgaga @gtrensch @heplesser @terhorstd