Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of NEST synaptic delay parameter #887

Closed
wants to merge 18 commits into from

Conversation

clinssen
Copy link
Contributor

@clinssen clinssen commented Mar 24, 2023

Synaptic delay and weight in NEST are a special case and should not be treated like any other parameter (or state variable). It should be get/set only using get_delay() and set_delay() inherited from the Connection base class. A member variable is already provided by the base class.

get_weight() and set_weight() should be defined by the synapse model, but a member variable is not yet provided by the base class. We could make it such that no state or parameter marked @nest::weight is needed for minimalistic models.

When a decorator is specified in the model, the parameter can only be get/set using the name given as part of the decorator, termed the "namespace name" (i.e. "weight" instead of "w" and "delay" for "d").

As part of this PR, ASTExternalVariable was refactored out and replaced by the alternate_name (and alternate_scope) fields of a regular ASTVariable.

Fixes #707.

@clinssen clinssen marked this pull request as draft March 24, 2023 20:32
@clinssen clinssen marked this pull request as ready for review September 18, 2023 12:58
@pnbabu
Copy link
Contributor

pnbabu commented Sep 19, 2023

As these decorators are specific to NEST, could we have these in the codegen_opts for the NEST target instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail with error in NEST code generator if @nest::delay is not supplied in synapse model
2 participants