Syn delay reprise #995
Closed
Syn delay reprise #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synaptic delay and weight in NEST are a special case and should not be treated like any other parameter (or state variable). It should be get/set only using
get_delay()andset_delay()inherited from theConnectionbase class. A member variable is already provided by the base class.get_weight()andset_weight()should be defined by the synapse model, but a member variable is not yet provided by the base class. We could make it such that no state or parameter marked@nest::weightis needed for minimalistic models.Replaces #887.
Fixes #707.
Should be merged only after #879.