Skip to content

Conversation

davids-sparkshare
Copy link
Contributor

This adds a section on how to replace APP_* token providers in testing. This follows the description by @kamilmysliwiec in nestjs/nest#4053 . I've used the solution in my project and it worked great.

Thanks to @jmcdo29 who pointed me to that issue when I was struggling with this.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[x] Docs
[ ] Other... Please describe:

What is the current behavior?

Issue Number: nestjs/nest#5821

What is the new behavior?

more docs

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

This adds a section on how to replace `APP_*` token providers in testing. This follows the description by @kamilmysliwiec in nestjs/nest#4053 . I've used the solution in my project and it worked great.

Thanks to @jmcdo29 who pointed me to that issue when I was struggling with this.
Co-authored-by: Johannes Schobel <johannesschobel@users.noreply.github.com>
@kamilmysliwiec
Copy link
Member

Can you review @jmcdo29 by chance? 🤞

Co-authored-by: Kamil Mysliwiec <mail@kamilmysliwiec.com>
Co-authored-by: Jay McDoniel <jmcdo29@gmail.com>
@davids-sparkshare
Copy link
Contributor Author

Applied all suggestions from code review.

@kamilmysliwiec
Copy link
Member

LGTM

@kamilmysliwiec kamilmysliwiec merged commit ccce2be into nestjs:master Jan 7, 2021
@davids-sparkshare davids-sparkshare deleted the patch-1 branch January 9, 2021 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants