-
Notifications
You must be signed in to change notification settings - Fork 2k
Add a section for overriding APP_* token providers #1578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a section on how to replace `APP_*` token providers in testing. This follows the description by @kamilmysliwiec in nestjs/nest#4053 . I've used the solution in my project and it worked great. Thanks to @jmcdo29 who pointed me to that issue when I was struggling with this.
Co-authored-by: Johannes Schobel <johannesschobel@users.noreply.github.com>
johannesschobel
approved these changes
Dec 12, 2020
Can you review @jmcdo29 by chance? 🤞 |
jmcdo29
suggested changes
Dec 14, 2020
Co-authored-by: Kamil Mysliwiec <mail@kamilmysliwiec.com> Co-authored-by: Jay McDoniel <jmcdo29@gmail.com>
Applied all suggestions from code review. |
jmcdo29
approved these changes
Dec 28, 2020
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a section on how to replace
APP_*
token providers in testing. This follows the description by @kamilmysliwiec in nestjs/nest#4053 . I've used the solution in my project and it worked great.Thanks to @jmcdo29 who pointed me to that issue when I was struggling with this.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: nestjs/nest#5821
What is the new behavior?
more docs
Does this PR introduce a breaking change?
Other information