Skip to content

Conversation

ace03uec
Copy link
Contributor

@ace03uec ace03uec commented Feb 16, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Docs
  • Other... Please describe:

What is the current behavior?

The current behaviour performs an incorrect check for marking a service as down.

Issue Number: N/A

What is the new behavior?

This change makes this check consistent with the earlier example and fixes the same.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kamilmysliwiec kamilmysliwiec merged commit d51e129 into nestjs:master Feb 17, 2025
4 checks passed
@ace03uec ace03uec deleted the fix-migration-guide-logic branch February 17, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants